C front-end: fix processing of alignment and packing attributes #8454
+274
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8454 +/- ##
========================================
Coverage 80.37% 80.37%
========================================
Files 1686 1686
Lines 206888 206928 +40
Branches 73 78 +5
========================================
+ Hits 166288 166325 +37
- Misses 40600 40603 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kroening
reviewed
Nov 26, 2024
| power(2, align_int->floorPow2()) != *align_int) | ||
| { | ||
| throw errort().with_location(type.source_location()) | ||
| << "alignment is not a positive power of 2"; |
There was a problem hiding this comment.
Is that a requirement in the standard?
There was a problem hiding this comment.
C11 6.2.8 "Alignment of objects" includes the following sentence: "Every valid alignment value shall be a nonnegative integral power of two."
Packing needs to be evaluated as part of the definition of the type while alignment applies also when using a type. The position of the attribute also requires extra care as some positions are accepted by GCC (and warned about by Clang) while actually being ignored. Fixes: diffblue#8443
tautschnig
force-pushed
the
fix-8443-attributes
branch
from
5eea045 to
0367e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packing needs to be evaluated as part of the definition of the type while alignment applies also when using a type. The position of the attribute also requires extra care as some positions are accepted by GCC (and warned about by Clang) while actually being ignored.
Fixes: #8443